-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*.py: s/python/python3/ (exclude tests) #3647
Conversation
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
1 similar comment
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
@kira-syslogng ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The CI sadly fails, the one regarding mac os is an issue on the current master also, you can ignore that. The other one is a style check of the commit message, it does not like the *
in the*.py
, I would just replace it with python:
and that should help.
Build SUCCESS |
As stated by syslog-ng#3603 python2 is EOL. Fix all shebangs calling python instead of python3 except the tests. (correcting lib/merge-grammar.py) Signed-off-by: Joe Slater <joe.slater@windriver.com> (adding the rest) Signed-off-by: Yi Fan Yu <yifan.yu@windriver.com>
done. |
Build SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'm waiting with the merge, until an internal test is not finished.
…log-ng.spec After PR syslog-ng#3647 lib/merge-grammar.py has python3 in it's shebang instead of "python", there is no need for the sed command anymore in the .spec file (python2 is not supported). Also, the sed expression currently creates an invalid python reference, see result: "#!/usr/bin/python33" Packaging CI jobs doesn't hit this issue, as they are creating packages from tarball (as intended due to bison v3.7.6 which is not yet available on many platforms). This bug prevented releasing on rpm platforms where the grammar files are changed. Signed-off-by: Gabor Nagy <gabor.nagy@oneidentity.com>
As stated by #3603
python2 is EOL.
Fix all shebangs calling python instead of python3
except the tests.
(correcting lib/merge-grammar.py)
Signed-off-by: Joe Slater joe.slater@windriver.com
(adding the rest)2a1a44fade7e73872361568bd2dad235d083dcf1
Signed-off-by: Yi Fan Yu yifan.yu@windriver.com